Avoid crash when a known command's required arg ends a group#190
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
This does not seem to fully fix it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TexSoup(r"{\label}")raisedTypeError: Malformed argumentbecause\labelhas a known one-required-argument signature, and when its argument is absent at the end of a group the parser consumed the closing}as the argument, leaving the group unterminated.read_arg_requirednow skips the fallback "use the next token as the argument" branch when that next token is a closing delimiter (}or]), so a missing required argument is simply left empty instead of swallowing the delimiter.The reduced case is
{\label}, but the same crash hit the original\tikzmath{\label = 1;}/\node[...] {\label}document in the issue.Validation
python3 -m pytest(190 passed)test_known_command_missing_arg_at_group_endfails on the current parser and passes with this change.