get: return faster if key is not present#5
Open
Kikobeats wants to merge 1 commit into
Open
Conversation
Collaborator
|
hi @Kikobeats can you demonstrate this faster using the lru benchmark? (https://github.com/dominictarr/bench-lru) |
Collaborator
Author
|
yes, my local benchmarks looks faster because it exists early |
Owner
|
@Kikobeats show us the results please! |
Collaborator
Author
|
added! 💃 |
Owner
|
@Kikobeats added where? |
Collaborator
Author
|
@dominictarr ops, in the first comment. |
Collaborator
|
@Kikobeats in terms of the benchmark code - did you modify it all? If so could you share the benchmark code somewhere too? (a gist would be fine) |
Owner
|
my hunch is that this that difference is a fluke, because you have only added extra code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after