Map is now faster than object (1.5x get, 2.6x set)#21
Open
davidmarkclements wants to merge 3 commits into
Open
Map is now faster than object (1.5x get, 2.6x set)#21davidmarkclements wants to merge 3 commits into
davidmarkclements wants to merge 3 commits into
Conversation
added 2 commits
July 18, 2019 16:38
Collaborator
Author
|
one way this could break user code, is if someone is doing this: That will work with objects, but not maps. We can either protect against by converting numbers to strings (might have a perf penalty) or we can release as major |
Owner
|
looks good. If in doubt, just release as major. I don't think numbers as strings for keys should be explicitly supported. |
|
Nice find @davidmarkclements |
|
For what it is worth, @sindresorhus implements equivalent logic in https://www.npmjs.com/package/quick-lru |
|
Would love to see this in a future release. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
Mapis now significantly faster than using objects, and this has an added advantage of using objects for keysbench output for this branch:
bench output for master branch