fix: type definitions for use with require#24
Open
Gozala wants to merge 1 commit into
Open
Conversation
1 task
|
@dominictarr it would be great if this could be merged, types are completely broken with node16 moduleResolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes typedefs so that module does not pretends to be a ES module, which causes problems like this:
And misleads users to do
require('hashlru').defaultinstead, which than breaks at runtime because there is noexports.default.Suggested syntax is recognized by TS as CommonJS module, which works as expected when importing from commonjs and also works correctly when imported from TS / ESM models if
esModuleInterop: trueis set intsconfig.json