apfloat raw_mul precompute exponent offset depending on product's upper binade#4429
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
apfloat raw_mul precompute exponent offset depending on product's upper binade#4429copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…er binade This change takes logic pertaining to the product's fraction carry over and precomputes as much as possible about the result exponent and special cases depending on whether the product's fraction is in [1.0, 2.0) or [2.0, 4.0), i.e. whether or not it requires carry over handling. In doing so, we reduce the critical path by removing computation blocked on the multiply PiperOrigin-RevId: 934175303
edb90eb to
cf59897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apfloat raw_mul precompute exponent offset depending on product's upper binade
This change takes logic pertaining to the product's fraction carry over and precomputes as much as possible about the result exponent and special cases depending on whether the product's fraction is in [1.0, 2.0) or [2.0, 4.0), i.e. whether or not it requires carry over handling.
In doing so, we reduce the critical path by removing computation blocked on the multiply