Fix bug with a ProcDef which creates a channel and deals out both ends.#4433
Merged
Conversation
bb699bc to
41c2416
Compare
This case was already working in the bytecode interpreter but not in IR conversion, due to the different ways of managing channels. The problem in IR conversion was that we would only register a channel if one end was a member of the proc that creates it. PiperOrigin-RevId: 934578048
41c2416 to
33d7c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug with a ProcDef which creates a channel and deals out both ends.
This case was already working in the bytecode interpreter but not in IR conversion, due to the different ways of managing channels.
The problem in IR conversion was that we would only register a channel if one end was a member of the proc that creates it.