Repository navigation
Description
Before reporting an issue
- I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.
Area
infinispan
Bug Description
ClockSkewTimestampSample, introduced with the clock skew detection in #54284, is annotated with @ProtoTypeId but is not listed in includeClasses of KeycloakModelSchema. It is therefore missing from the generated ProtoStream schema and cannot be marshalled. Additionally, the record has no explicit @ProtoField numbers, so the wire format depends on the order of the record components.
Version
nightly (main, 27.0.0)
Expected behavior
The clock skew sample is published to the work cache and received by the other nodes, which log a warning if their clocks differ by more than the threshold.
Actual behavior
The sample is not part of the marshalling schema. As soon as it needs to be serialized, which is the case with more than one node or with a remote cache, publishing it is expected to fail with a marshalling error on every sampling interval, and no clock skew is ever reported. With a single node nothing is serialized, so it goes unnoticed. The existing ClockSkewDetectionTest only puts the sample into the local cache, so it doesn't detect this.
How to Reproduce?
- Start two Keycloak nodes in the same cluster from main.
- Wait for the clock skew sampling interval (60 seconds by default).
- Observe the errors from
ClockSkewDetectionTaskin the log.
This has been derived from the code and not yet reproduced with a running two-node cluster.
Anything else?
A fix is proposed in #55235. For rolling updates from 26.8 to 27.0, 26.8 nodes need the class and the type ID registered as well, see #55231.
Metadata
Metadata
Assignees
Labels
Type
Fields
Projects
- StatusShow more project fieldsOpen
Activity
Register ClockSkewTimestampSample in the marshalling schema
Register ClockSkewTimestampSample in the marshalling schema