Skip to content

Migrates SamlClientTest using new Testframework#50127

Draft
jimmychakkalakal wants to merge 1 commit into
keycloak:mainfrom
jimmychakkalakal:test_migration/Migrate_SamlClientTest
Draft

Migrates SamlClientTest using new Testframework#50127
jimmychakkalakal wants to merge 1 commit into
keycloak:mainfrom
jimmychakkalakal:test_migration/Migrate_SamlClientTest

Conversation

@jimmychakkalakal

@jimmychakkalakal jimmychakkalakal commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Migrates SamlClientTest using new Keycloak Testframework

Closes #48202

@jimmychakkalakal jimmychakkalakal force-pushed the test_migration/Migrate_SamlClientTest branch from 40e4d41 to b4edf0c Compare June 18, 2026 15:19
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jun 18, 2026
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

keycloak-github-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLLoginResponseHandlingTest#testAttributes

Keycloak CI - Adapter IT Strict Cookies

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/demo/login-action ; actual URL: https://localhost:8643/employee2/ ==> expected: <true> but was: <false> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
...

Report flaky test

@jimmychakkalakal
Migrates SamlClientTest using new Testframework
d56c88f 
Closes keycloak#48202

Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
@jimmychakkalakal jimmychakkalakal force-pushed the test_migration/Migrate_SamlClientTest branch from b4edf0c to d56c88f Compare June 19, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

flaky-test team/core-protocols

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate SamlClientTest

2 participants

@jimmychakkalakal @stianst