Skip to content

pkp/pkp-lib#12637 validate custom DOI suffix patterns #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bozana merged 2 commits into from
Jun 23, 2026
+28 −8
Merged

pkp/pkp-lib#12637 validate custom DOI suffix patterns #5601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0ecdd1
pkp/pkp-lib#12637 validate that custom DOI suffixes patterns are not …
bozana Jun 16, 2026
bc3de82
pkp/pkp-lib#12637 submodule update
bozana Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions classes/services/ContextService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* @file classes/services/ContextService.php
*
Expand All @@ -24,6 +25,7 @@
use APP\subscription\InstitutionalSubscriptionDAO;
use APP\subscription\SubscriptionTypeDAO;
use PKP\config\Config;
use PKP\context\Context;
use PKP\db\DAORegistry;
use PKP\file\TemporaryFileManager;
use PKP\plugins\Hook;
Expand Down Expand Up @@ -205,16 +207,12 @@ public function validateContext($hookName, $args)
$props = $args[2];
$allowedLocales = $args[3];

if (!isset($props['journalThumbnail'])) {
return;
}

// If a journal thumbnail is passed, check that the temporary file exists
// and the current user owns it
$user = Application::get()->getRequest()->getUser();
$userId = $user ? $user->getId() : null;
$temporaryFileManager = new TemporaryFileManager();
if (isset($props['journalThumbnail']) && empty($errors['journalThumbnail'])) {
$user = Application::get()->getRequest()->getUser();
$userId = $user ? $user->getId() : null;
$temporaryFileManager = new TemporaryFileManager();
foreach ($allowedLocales as $localeKey) {
if (empty($props['journalThumbnail'][$localeKey]) || empty($props['journalThumbnail'][$localeKey]['temporaryFileId'])) {
continue;
Expand All @@ -227,5 +225,27 @@ public function validateContext($hookName, $args)
}
}
}

// Disallow empty custom DOI suffix pattern for issues when the custom pattern type is selected
if (
isset($props[Context::SETTING_DOI_SUFFIX_TYPE]) ||
isset($props[Context::SETTING_ENABLED_DOI_TYPES]) ||
isset($props[Repo::doi()::CUSTOM_ISSUE_PATTERN])
) {
$context = Application::get()->getRequest()->getContext();
$suffixType = $props[Context::SETTING_DOI_SUFFIX_TYPE]
?? $context?->getData(Context::SETTING_DOI_SUFFIX_TYPE);
$enabledTypes = $props[Context::SETTING_ENABLED_DOI_TYPES]
?? $context?->getData(Context::SETTING_ENABLED_DOI_TYPES)
?? [];

if (
$suffixType === Repo::doi()::SUFFIX_CUSTOM_PATTERN &&
in_array(Repo::doi()::TYPE_ISSUE, $enabledTypes) &&
empty($props[Repo::doi()::CUSTOM_ISSUE_PATTERN])
) {
$errors[Repo::doi()::CUSTOM_ISSUE_PATTERN] = [__('doi.manager.settings.doiSuffixPattern.required')];
}
}
}
}
2 changes: 1 addition & 1 deletion lib/pkp
Open in desktop
Submodule pkp updated 9 files
+2 −0 classes/mail/mailables/DiscussionCopyediting.php
+2 −0 classes/mail/mailables/DiscussionProduction.php
+2 −0 classes/mail/mailables/DiscussionReview.php
+2 −0 classes/mail/mailables/DiscussionSubmission.php
+1 −1 classes/mail/traits/Discussion.php
+3 −0 classes/mail/traits/Recipient.php
+48 −3 classes/mail/traits/Unsubscribe.php
+44 −3 classes/services/PKPContextService.php
+3 −0 locale/en/manager.po
Loading