Initial HalfOps features by skralg · Pull Request #1825 · znc/znc

skralg · 2022-02-26T02:37:53Z

Almost entirely copy/paste with small edits to function names.
Added autohalfop module, nearly the same as the autoop module.

DarthGandalf · 2022-02-26T14:46:21Z

+    /** Called when a nick is dehalfopped on a channel */
+    virtual void OnDeHalfOp2(const CNick* pOpNick, const CNick& Nick,
+                         CChan& Channel, bool bNoChange);
+    virtual void OnDeHalfOp(const CNick& OpNick, const CNick& Nick, CChan& Channel,


If adding new callbacks, need to update modperl and modpython

modperl and modpython updated

You've missed the function.in files.

DarthGandalf · 2022-02-26T14:48:51Z

+    Info.SetWikiPage("autohalfop");
+}
+
+NETWORKMODULEDEFS(CAutoHalfOpMod, t_s("Auto halfop the good people"))


We shouldn't copypaste/duplicate code like that. A better way would be to have a single module which supports ops, voices, halfops

Perhaps that shall be my second contribution.

Perhaps it shall.

I believe merging this PR can wait until that's done though.

codecov · 2022-02-26T14:58:43Z

Codecov Report

❌ Patch coverage is 1.04167% with 665 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.91%. Comparing base (9be0cae) to head (4ff25a5).
⚠️ Report is 468 commits behind head on master.

Files with missing lines	Patch %	Lines
modules/autohalfop.cpp	0.78%	377 Missing ⚠️
modules/automode.cpp	1.12%	264 Missing ⚠️
src/Modules.cpp	0.00%	12 Missing ⚠️
src/Chan.cpp	9.09%	10 Missing ⚠️
modules/modperl/startup.pl	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
- Coverage   41.87%   40.91%   -0.97%     
==========================================
  Files         122      124       +2     
  Lines       27799    28471     +672     
  Branches       33       33              
==========================================
+ Hits        11642    11649       +7     
- Misses      16132    16797     +665     
  Partials       25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Updated missed calls in modperl and modpython.

Logic updates.

skralg · 2022-02-27T16:31:30Z

Ready for another look

skralg · 2022-02-28T16:14:43Z

I've added a new 'automode' module that can do automatic arbitrary mode changes.

skralg · 2022-03-03T14:51:27Z

@DarthGandalf Have you looked at the new automode module yet?

DarthGandalf

To clarify: it doesn't check the key like autoop did?

DarthGandalf · 2022-03-03T21:42:58Z

+        if (Nick.GetNick() == GetNetwork()->GetIRCNick().GetNick()) {
+            const map<CString, CNick>& msNicks = Channel.GetNicks();
+            for (const auto& it : msNicks) {
+                if (!it.second.HasPerm(CChan::HalfOp)) {


Are you sure?

Ah, good catch. That needs to become more robust.

DarthGandalf · 2022-03-03T21:44:13Z

+                    "[channels]"));
+        } else if (sMode != "q" && sMode != "a" && sMode != "o" &&
+                   sMode != "h" && sMode != "v") {
+            PutModule("<mode> must be one of the following: qaohv");


You missed t_s

It seems to work fine.. what is t_s anyway?

skralg · 2022-03-05T03:01:14Z

To clarify: it doesn't check the key like autoop did?

I removed the key mechanism altogether because I don't know a single person who doesn't just use NOKEY. Having to request it sort of defeats the purpose of calling it 'auto'...

DarthGandalf · 2022-03-05T13:05:26Z

t_s is for localisation support. Visible messages should be translateable Key is for efnet etc. You and another person add each other with the same key, and the module cryptographically checks that the key is the same instead of only relying on hostmask сб, 5 мар. 2022 г., 03:01 Jonathan Rudolph ***@***.***>:

…

I removed the key mechanism altogether because I don't know a single person who doesn't just use *NOKEY*. Having to request it sort of defeats the purpose of calling it 'auto'... — Reply to this email directly, view it on GitHub <#1825 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACPLZCCDDCK7YOQDWYZDY3U6LFALANCNFSM5PL2RDBQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

DarthGandalf · 2022-03-05T13:08:06Z

It's still auto, because module requests it itself when nick and host match сб, 5 мар. 2022 г., 03:01 Jonathan Rudolph ***@***.***>:

…

I removed the key mechanism altogether because I don't know a single person who doesn't just use *NOKEY*. Having to request it sort of defeats the purpose of calling it 'auto'... — Reply to this email directly, view it on GitHub <#1825 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACPLZCCDDCK7YOQDWYZDY3U6LFALANCNFSM5PL2RDBQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Initial HalfOps features

ed590f6

DarthGandalf reviewed Feb 26, 2022

View reviewed changes

skralg added 2 commits February 26, 2022 19:42

No need for backward compatibility, so remove '2' variants.

444f31b

Updated missed calls in modperl and modpython.

Fix for some types which were not obviously wrong.

775a696

Logic updates.

skralg added 3 commits February 27, 2022 23:20

Updating the functions.in files for swig

06fa6b1

Update modperl and modpython to reflect functions.in

315a99f

Initial commit of automode module

4ff25a5

DarthGandalf reviewed Mar 3, 2022

View reviewed changes

RealKindOne mentioned this pull request May 4, 2025

automode.cpp: Support owner/protect/op/half-op/voice modes #1948

Open

Uh oh!

Conversation

skralg commented Feb 26, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

skralg commented Feb 27, 2022

Uh oh!

skralg commented Feb 28, 2022

Uh oh!

skralg commented Mar 3, 2022

Uh oh!

DarthGandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skralg commented Mar 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DarthGandalf commented Mar 5, 2022 via email

Uh oh!

DarthGandalf commented Mar 5, 2022 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Feb 26, 2022 •

edited

Loading

skralg commented Mar 5, 2022 •

edited

Loading