Attachment 8775107 Details for Bug 1282408

[patch] 0001-Coverity-749957-Add-ignore-initialization-check-flag.patch

0001-Coverity-749957-Add-ignore-initialization-check-flag.patch (text/plain), 1.74 KB, created by Paul Bignier

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Bignier

Size: 1.74 KB

patch

obsolete

>From 8996564cfdcc575d046d40b0b63cd7c5831a342d Mon Sep 17 00:00:00 2001
>From: Paul Bignier <paul.bignier@gmail.com>
>Date: Wed, 27 Jul 2016 13:57:33 +0200
>Subject: [PATCH] [Coverity #749957] Add ignore initialization check flag for
> variables from SizeSpec
>
> * Each one of these variables come with a boolean XSpecified. As it is false in the ctor, the variables shouldn't be initialized
>---
> embedding/components/windowwatcher/nsWindowWatcher.cpp | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/embedding/components/windowwatcher/nsWindowWatcher.cpp b/embedding/components/windowwatcher/nsWindowWatcher.cpp
>index 0dbc990..90a5c63 100644
>--- a/embedding/components/windowwatcher/nsWindowWatcher.cpp
>+++ b/embedding/components/windowwatcher/nsWindowWatcher.cpp
>@@ -384,22 +384,22 @@ struct SizeSpec
>     , mOuterHeightSpecified(false)
>     , mInnerWidthSpecified(false)
>     , mInnerHeightSpecified(false)
>     , mUseDefaultWidth(false)
>     , mUseDefaultHeight(false)
>   {
>   }
> 
>-  int32_t mLeft;
>-  int32_t mTop;
>-  int32_t mOuterWidth;  // Total window width
>-  int32_t mOuterHeight; // Total window height
>-  int32_t mInnerWidth;  // Content area width
>-  int32_t mInnerHeight; // Content area height
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mLeft;
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mTop;
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mOuterWidth;  // Total window width
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mOuterHeight; // Total window height
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mInnerWidth;  // Content area width
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mInnerHeight; // Content area height
> 
>   bool mLeftSpecified;
>   bool mTopSpecified;
>   bool mOuterWidthSpecified;
>   bool mOuterHeightSpecified;
>   bool mInnerWidthSpecified;
>   bool mInnerHeightSpecified;
> 
>-- 
>1.8.3.1
>

Actions: View | Diff | Review

Attachments on bug 1282408: 8765437 | 8765842 | 8765844 | 8765891 | 8765901 | 8766283 | 8766288 | 8774695 | 8774702 | 8774704 | 8774727 | 8774738 | 8775045 | 8775107 | 8775117 | 8775121 | 8775130 | 8775139 | 8775141 | 8775519 | 8775560 | 8775577 | 8775599 | 8783946 | 8783955 | 8783956 | 8783963 | 8786330 | 8786345 | 8787093 | 8790295 | 8790304 | 8790645 | 8790699 | 8790702 | 8790731 | 8791536 | 8791622 | 8791937 | 8792801 | 8794853 | 8794855 | 8795169 | 8795228 | 8795236 | 8795246 | 8795282 | 8795333 | 8795623 | 8795632 | 8795642 | 8795644 | 8795690 | 8796067 | 8796100