Attachment 8795333 Details for Bug 1282408

[patch] Add ignore-initialization-check annotation to which_ from CalleeDesc

add-ignore-initialization-check-flag-for-which_-from-CalleeDesc (text/plain), 1022 bytes, created by Paul Bignier

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Bignier

Size: 1022 bytes

patch

obsolete

># HG changeset patch
># User Paul Bignier <paul.bignier@gmail.com>
># Date 1474990173 -7200
>#      Tue Sep 27 17:29:33 2016 +0200
># Node ID 8a56d4453ece80fd1e247ab741c06f37ef4b0590
># Parent  53518515dd8b19146cb402b5e234c356d1613ef3
>Bug 1282408 - Add ignore-initialization-check annotation to which_ from CalleeDesc
>
>diff --git a/js/src/asmjs/WasmTypes.h b/js/src/asmjs/WasmTypes.h
>--- a/js/src/asmjs/WasmTypes.h
>+++ b/js/src/asmjs/WasmTypes.h
>@@ -1094,17 +1094,18 @@ class CalleeDesc
>         // Call a C++ function identified by SymbolicAddress.
>         Builtin,
> 
>         // Like Builtin, but automatically passes Instance* as first argument.
>         BuiltinInstanceMethod
>     };
> 
>   private:
>-    Which which_;
>+    // which_ shall be initialized in the static constructors
>+    MOZ_INIT_OUTSIDE_CTOR Which which_;
>     union U {
>         U() {}
>         uint32_t funcDefIndex_;
>         struct {
>             uint32_t globalDataOffset_;
>         } import;
>         struct {
>             uint32_t globalDataOffset_;

Flags:

jorendorff: review+

Actions: View | Diff | Review

Attachments on bug 1282408: 8765437 | 8765842 | 8765844 | 8765891 | 8765901 | 8766283 | 8766288 | 8774695 | 8774702 | 8774704 | 8774727 | 8774738 | 8775045 | 8775107 | 8775117 | 8775121 | 8775130 | 8775139 | 8775141 | 8775519 | 8775560 | 8775577 | 8775599 | 8783946 | 8783955 | 8783956 | 8783963 | 8786330 | 8786345 | 8787093 | 8790295 | 8790304 | 8790645 | 8790699 | 8790702 | 8790731 | 8791536 | 8791622 | 8791937 | 8792801 | 8794853 | 8794855 | 8795169 | 8795228 | 8795236 | 8795246 | 8795282 | 8795333 | 8795623 | 8795632 | 8795642 | 8795644 | 8795690 | 8796067 | 8796100