Attachment 8791622 Details for Bug 1282408

[patch] add ignore initialization check flag for mSourceGraphicIndex and mSourceAlphaIndex from nsSVGFilterInstance

-ignore-initialization-check-flag-for-mSourceGraphicIndex-mSourceAlphaIndex-from-nsSVGFilterInstance (text/plain), 1.49 KB, created by Paul Bignier

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Bignier

Size: 1.49 KB

patch

obsolete

># HG changeset patch
># User Paul Bignier <paul.bignier@gmail.com>
># Date 1473950505 -7200
>#      Thu Sep 15 16:41:45 2016 +0200
># Node ID 6cd7701aee2e86c5fad80217478585a5d784f207
># Parent  f5d043ce6d36a3c461cbd829d4a4a38394b7c436
>Bug 1282408 - add ignore initialization check flag for mSourceGraphicIndex and mSourceAlphaIndex from nsSVGFilterInstance
>
>diff --git a/layout/svg/nsSVGFilterInstance.h b/layout/svg/nsSVGFilterInstance.h
>--- a/layout/svg/nsSVGFilterInstance.h
>+++ b/layout/svg/nsSVGFilterInstance.h
>@@ -250,26 +250,26 @@ private:
>   /**
>    * The 'primitiveUnits' attribute value (objectBoundingBox or userSpaceOnUse).
>    */
>   uint16_t mPrimitiveUnits;
> 
>   /**
>    * The index of the FilterPrimitiveDescription that this SVG filter should use
>    * as its SourceGraphic, or the SourceGraphic keyword index if this is the
>-   * first filter in a chain.
>+   * first filter in a chain. Initialized in BuildPrimitives
>    */
>-  int32_t mSourceGraphicIndex;
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mSourceGraphicIndex;
> 
>   /**
>    * The index of the FilterPrimitiveDescription that this SVG filter should use
>    * as its SourceAlpha, or the SourceAlpha keyword index if this is the first
>-   * filter in a chain.
>+   * filter in a chain. Initialized in BuildPrimitives
>    */
>-  int32_t mSourceAlphaIndex;
>+  MOZ_INIT_OUTSIDE_CTOR int32_t mSourceAlphaIndex;
> 
>   /**
>    * SourceAlpha is available if GetOrCreateSourceAlphaIndex has been called.
>    */
>   int32_t mSourceAlphaAvailable;
> 
>   bool mInitialized;
> };

Flags:

dholbert: review+

Actions: View | Diff | Review

Attachments on bug 1282408: 8765437 | 8765842 | 8765844 | 8765891 | 8765901 | 8766283 | 8766288 | 8774695 | 8774702 | 8774704 | 8774727 | 8774738 | 8775045 | 8775107 | 8775117 | 8775121 | 8775130 | 8775139 | 8775141 | 8775519 | 8775560 | 8775577 | 8775599 | 8783946 | 8783955 | 8783956 | 8783963 | 8786330 | 8786345 | 8787093 | 8790295 | 8790304 | 8790645 | 8790699 | 8790702 | 8790731 | 8791536 | 8791622 | 8791937 | 8792801 | 8794853 | 8794855 | 8795169 | 8795228 | 8795236 | 8795246 | 8795282 | 8795333 | 8795623 | 8795632 | 8795642 | 8795644 | 8795690 | 8796067 | 8796100