Attachment 8790699 Details for Bug 1282408

[patch] add ignore initialization check flag for mDashOffset mStrokeWidth from SVGContextPaint

add-ignore-initialization-check-flag-for-mDashOffset-mStrokeWidth-from-SVGContextPaint (text/plain), 1.16 KB, created by Paul Bignier

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Bignier

Size: 1.16 KB

patch

obsolete

># HG changeset patch
># User Paul Bignier <paul.bignier@gmail.com>
># Date 1473771573 -7200
>#      Tue Sep 13 14:59:33 2016 +0200
># Node ID 0c1c0e72c6de1949096d651e6aa55e5b0deac1f2
># Parent  f5d043ce6d36a3c461cbd829d4a4a38394b7c436
>Bug 1282408 - add ignore initialization check flag for mDashOffset mStrokeWidth from SVGContextPaint
>
>diff --git a/layout/svg/SVGContextPaint.h b/layout/svg/SVGContextPaint.h
>--- a/layout/svg/SVGContextPaint.h
>+++ b/layout/svg/SVGContextPaint.h
>@@ -77,19 +77,20 @@ public:
>     return mDashOffset;
>   }
> 
>   gfxFloat GetStrokeWidth() {
>     return mStrokeWidth;
>   }
> 
> private:
>+  // Member-vars are initialized in InitStrokeGeometry.
>   FallibleTArray<gfxFloat> mDashes;
>-  gfxFloat mDashOffset;
>-  gfxFloat mStrokeWidth;
>+  MOZ_INIT_OUTSIDE_CTOR gfxFloat mDashOffset;
>+  MOZ_INIT_OUTSIDE_CTOR gfxFloat mStrokeWidth;
> };
> 
> /**
>  * RAII class used to temporarily set and remove an SVGContextPaint while a
>  * piece of SVG is being painted.  The context paint is set on the SVG's owner
>  * document, as expected by SVGContextPaint::GetContextPaint.  Any pre-existing
>  * context paint is restored after this class removes the context paint that it
>  * set.

Flags:

dholbert: review+

Actions: View | Diff | Review

Attachments on bug 1282408: 8765437 | 8765842 | 8765844 | 8765891 | 8765901 | 8766283 | 8766288 | 8774695 | 8774702 | 8774704 | 8774727 | 8774738 | 8775045 | 8775107 | 8775117 | 8775121 | 8775130 | 8775139 | 8775141 | 8775519 | 8775560 | 8775577 | 8775599 | 8783946 | 8783955 | 8783956 | 8783963 | 8786330 | 8786345 | 8787093 | 8790295 | 8790304 | 8790645 | 8790699 | 8790702 | 8790731 | 8791536 | 8791622 | 8791937 | 8792801 | 8794853 | 8794855 | 8795169 | 8795228 | 8795236 | 8795246 | 8795282 | 8795333 | 8795623 | 8795632 | 8795642 | 8795644 | 8795690 | 8796067 | 8796100