chore: housekeeping pass (lint, types, dead code)#144
Conversation
The lint config already ignores `_`-prefixed args and ES2019 lets us omit the catch binding entirely, so two eslint-disable-next-line comments in Sidebar.tsx and ResetPasswordView.tsx were doing no work. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Nothing imports from src/components/ParametricEditor.tsx — every caller already imports ParametricEditorView directly from src/views/. The file's own comment said it existed for backwards compatibility, but since this is a private webapp there are no external consumers to preserve. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The Built With section claimed React 18, but package.json and the README badge both say React 19.1. Bring the prose in line. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The package.json name was still "vite-react-typescript-starter" from the initial scaffold. It surfaces in npm logs and lockfiles, so set it to the actual project name. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Mirrors the existing `format` script with `--check` so CI / pre-merge hooks can verify formatting without writing to the working tree. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Greptile SummaryA pure housekeeping pass: removes a dead re-export shim, drops now-redundant
Confidence Score: 4/5Safe to merge — all changes are metadata, dead code removal, and lint cleanup with no runtime paths touched. Every diff is either a deletion with confirmed zero importers, a comment/directive removal, or a package.json/README metadata update. The only open question is that the new format:check script has no enforcement path yet — it won't catch drift unless explicitly called or wired into the pre-commit hook or a CI step. No files require special attention; package.json is the only file where the noted gap lives. Important Files Changed
Reviews (1): Last reviewed commit: "chore: add format:check script" | Re-trigger Greptile |
| "typecheck": "tsc -b --noEmit", | ||
| "lint:supabase": "deno lint supabase", | ||
| "format": "prettier --write .", | ||
| "format:check": "prettier --check .", |
There was a problem hiding this comment.
format:check is defined but not enforced anywhere
The script exists, but the pre-commit hook (.husky/pre-commit) only runs tsc -b and lint-staged, and there are no CI workflow files in the repo. lint-staged already runs prettier --write on staged files, which auto-fixes rather than gates. format:check will only catch formatting drift if someone manually calls it — it won't block a mis-formatted commit or a merge. Worth wiring it into the pre-commit hook or a CI step to close that gap.
Summary
A small no-behavior-change cleanup pass. Each commit is independent and self-explanatory; trivial to revert any of them individually.
Changes
chore: drop redundant eslint-disable directives—src/components/Sidebar.tsxandsrc/views/ResetPasswordView.tsx. The lint config already ignores_-prefixed args, and ES2019 lets us drop the catch binding entirely. The disables were no-ops.chore: remove dead ParametricEditor re-export shim—src/components/ParametricEditor.tsxwas a 4-line re-export ofParametricEditorViewthat nothing in the repo imports. Its own comment said it existed for backwards compatibility, but this is a private webapp.docs: fix outdated React 18 reference in README— Built With section said React 18; package.json and the README badge both already say React 19.1.chore: rename package from default vite scaffold name to cadam—package.jsonname was stillvite-react-typescript-starter. It surfaces in npm logs / lockfile comments.chore: add format:check script— mirrors the existingformatscript with--checkso CI / pre-merge hooks can verify formatting without writing.Validation
npm run typecheck— clean.npm run lint—0 errors, 12 warnings(same baseline asmaster; remaining warnings arereact-refresh/only-export-componentson shadcn/ui files andreact-hooks/exhaustive-depsref-cleanup notes that need behavioral judgment to fix — out of scope for this pass).npm run format:check— clean.npm run build— could not verify in this sandbox (4 GB cgroup OOMs vite during transform of the 3,800-module graph, before any of these changes are reached). Thetsc -bportion that runs first does pass, and none of the diffs touch import graphs or build config, so build risk is low. Please run locally to confirm.Out of scope (deliberately untouched)
supabase/functions/**— per repo guidance.react-refreshwarnings — would mean splitting upstream-style files.react-hooks/exhaustive-depsref-cleanup warnings inuseOpenSCAD.ts/VisualCard.tsx— needs runtime reasoning.No user-visible behavior changes.
Test plan
npm installnpm run typechecknpm run lintnpm run build(full vite build — could not run in sandbox; main concern this PR can't self-verify)🤖 Generated with Claude Code
Summary by cubic
Housekeeping pass to remove dead code, clean up lint directives, and tighten project metadata. Removed unused
ParametricEditorre-export, dropped redundant eslint disables (simplified catch binding), renamed package tocadam, addedformat:checkforprettier, and updated README to React 19. No runtime behavior changes.Written for commit 353e27a. Summary will update on new commits.