Support preserving original package when remapping illegal names#1021
Open
JamesBraver wants to merge 1 commit into
Open
Support preserving original package when remapping illegal names#1021JamesBraver wants to merge 1 commit into
JamesBraver wants to merge 1 commit into
Conversation
- Add `mapClass(info, mapPackage)` to `NameGenerator` to control package remapping. - Implement package-aware naming in `AlphabetNameGenerator` and `IncrementingNameGenerator`. - Introduce `shouldMapPackage` in `NameGeneratorFilter` and all filter implementations to decide whether a class's package should be remapped. - Update `MappingGenerator` and `IllegalNameMappingTransformer` to use the new package mapping logic. - Fix argument order in `getMappedFieldName`/`getMappedMethodName` calls within `IllegalNameMappingTransformer`. - Add tests verifying that illegal class names are remapped while keeping legal packages intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapClass(info, mapPackage)toNameGeneratorto control package remapping.AlphabetNameGeneratorandIncrementingNameGenerator.shouldMapPackageinNameGeneratorFilterand all filter implementations to decide whether a class's package should be remapped.MappingGeneratorandIllegalNameMappingTransformerto use the new package mapping logic.getMappedFieldName/getMappedMethodNamecalls withinIllegalNameMappingTransformer.What's new
What's fixed