fix: correct interview preview URL generation logic#24
Open
sameertak wants to merge 2 commits into
Open
Conversation
sameertak
commented
Jun 18, 2025
- Fixed base_url fallback when undefined or in localhost mode
- Handled double https:// and undefined URLs correctly
- Improved handling for readable_slug and fallback URL cases
- Fixed base_url fallback when undefined or in localhost mode - Handled double https:// and undefined URLs correctly - Improved handling for readable_slug and fallback URL cases
Member
|
Looks like the ci checks are failing. |
Author
Updated the same. :D |
Member
i'm not sure why but it's still failing 😅. can you check if you missed something? @sameertak |
Author
Alright! Will look into the same and will update later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.