feat(helm): add deploymentAnnotations support to MCP server templates#2011
Open
pandacooming wants to merge 1 commit into
Open
feat(helm): add deploymentAnnotations support to MCP server templates#2011pandacooming wants to merge 1 commit into
pandacooming wants to merge 1 commit into
Conversation
Add custom annotations support to Deployment metadata for GitHub, Azure, Confluence, and Kubernetes Remediation MCP server templates. This enables users to add annotations like reloader.stakater.com/auto: 'true' for automatic pod restarts when referenced Secrets are updated. No-op when deploymentAnnotations is not set - existing deployments unaffected. Closes HolmesGPT#1995
|
|
❌ Deploy Preview for holmes-docs failed. Why did it fail? →
|
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughAdds ChangesMCP Server Deployment Annotations
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add custom annotations support to Deployment metadata for GitHub, Azure, Confluence, and Kubernetes Remediation MCP server templates.
Problem
The MCP server Deployment templates do not support custom annotations on the Deployment metadata. This prevents adding annotations like
reloader.stakater.com/auto: "true"needed to trigger automatic pod rolling restarts when referenced Secrets are updated by ESO (External Secrets Operator).Changes
deploymentAnnotationsblock to Deployment metadatadeploymentAnnotations: {}default to each server's config sectionVerification
Closes #1995
Summary by CodeRabbit