Add separate cursor and pointer options in DRM#785
Open
zhovner wants to merge 1 commit into
Open
Conversation
Pointer event delivery in the DRM platform was gated on cursor.enabled, which only becomes true after init_cursor() successfully allocates a hardware cursor plane. Drivers that lack a DRM_PLANE_TYPE_CURSOR plane (e.g. drm_simple_kms_helper panels) silently dropped every libinput pointer event, making COG_PLATFORM_DRM_CURSOR effectively the master switch for pointer input rather than just the on-screen cursor sprite as its name implies. Split into two independent options, each settable via env var, configuration file [drm] section, or -O command-line parameter: cursor draw a hardware cursor plane sprite (COG_PLATFORM_DRM_CURSOR) pointer forward libinput pointer events to WPE (COG_PLATFORM_DRM_POINTER) Both default to off; cursor=on implies pointer=on so the legacy single-flag behaviour of COG_PLATFORM_DRM_CURSOR=1 is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no way to enable touchpad/trackball/mouse input without drawing a mouse cursor sprite.
Pointer event delivery in the DRM platform was gated on cursor.enabled, which only becomes true after init_cursor() successfully allocates a hardware cursor plane. Drivers that lack a
DRM_PLANE_TYPE_CURSORplane (e.g. drm_simple_kms_helper panels) silently dropped every libinput pointer event, makingCOG_PLATFORM_DRM_CURSOReffectively the master switch for pointer input rather than just the on-screen cursor sprite as its name implies.Split into two independent options, each settable via env var, configuration file [drm] section, or -O command-line parameter:
cursor— draw a hardware cursor plane sprite (COG_PLATFORM_DRM_CURSOR)pointer— forward libinput pointer events to WPE (COG_PLATFORM_DRM_POINTER)Both default to off;
cursor=onimpliespointer=onso the legacy single-flag behaviour ofCOG_PLATFORM_DRM_CURSOR=1is preserved.