Include for TERRAIN#1381
Open
TehRealSalt wants to merge 1 commit into
Open
Conversation
Been hurting for this for a while, TERRAIN lumps are sensitive to load order when you use the multiple extensions trick to have more than one
Thanks for opening this PR! We'll review it soon.I'm a bot that checks for some common problems. I'll update this comment with anything I find. Nothing to report. Nice :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been hurting for this for a while. TERRAIN lumps are more sensitive to load order even compared to other script types, because they require blocks to be defined before referenced. This makes the multiple extensions trick even more annoying to juggle.
Uses
#includeas the keyword. Considered just usinginclude, since it's technically not a preprocessor, but GLDEFS does something similar and it also is using the #.I split off
S_ResolveIncludePathinto its own file because I wanted to use it and it was not specific to SNDINFO parsing at all. Lemme know if there's a better home I should bring it to.Checklist