chore: partial migration to ESM#5932
Open
mostafaNazari702 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5932 +/- ##
==========================================
- Coverage 80.85% 79.73% -1.13%
==========================================
Files 64 64
Lines 4566 4555 -11
Branches 958 979 +21
==========================================
- Hits 3692 3632 -60
- Misses 874 923 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c8f32f6 to
14d0459
Compare
3 tasks
f4d781c to
07e7073
Compare
5 tasks
JoshuaKGoldberg
requested changes
May 16, 2026
Member
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Great progress 🙂. As we mentioned in #5400 (comment), let's remove any major refactors / test shakeups to just leave the clean straightforward changes. LMK when you feel it's ready for re-review and I'll happily take a look. thanks!
07e7073 to
4e21670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
I will push commits one by one and request individual reviews for each. first, I considered creating separate PRs for different phases, expecting a large number of modified files. However, not counting test files, we’re now close to a full migration. What remains are a few high-risk and sensitive areas where I’d appreciate your guidance on how to proceed.
@mark-wiemer @JoshuaKGoldberg