Simplification of recently merged code from #2040 ("Fix zip observable to upstream (v2)").

Files Simplified

• Zip2Observable.scala — removed 2 redundant guards
• Zip3Observable.scala — removed 3 redundant guards
• Zip4Observable.scala — removed 4 redundant guards
• Zip5Observable.scala — removed 5 redundant guards
• Zip6Observable.scala — removed 6 redundant guards

Improvement Made

In each subscriber's onNext handler, the following pattern appeared for every source element variable:

elemAX = elem
if (!hasElemAX) hasElemAX = true

Setting a Boolean variable to true when it is already true is a no-op, so the if guard is redundant. The simplified form is:

elemAX = elem
hasElemAX = true

This removes dead branching logic and makes the intent clearer — upon receiving an element, we unconditionally record that we have it.

Changes Based On

• Fix zip observable to upstream (v2) #2040 — Fix zip observable to upstream (v2)

Testing

This is a pure simplification: no logic changes. The hasElemAX variables are only ever set to true in onNext and reset to false in rawOnNext (after emitting a combined element). The guard if (!hasElemAX) was never observable in behavior since writing true over true is idempotent.

References: §25036401375

Generated by Code Simplifier · ● 799.7K · ◷

To install this agentic workflow, run

gh aw add github/gh-aw/.github/workflows/code-simplifier.md@852cb06ad52958b402ed982b69957ffc57ca0619

• expires on Apr 29, 2026, 5:58 AM UTC