Plugin compatibility#1496
Open
edan-bainglass wants to merge 13 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 74.52% 74.89% +0.37%
==========================================
Files 117 115 -2
Lines 7442 7369 -73
==========================================
- Hits 5546 5519 -27
+ Misses 1896 1850 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edan-bainglass
commented
May 8, 2026
Comment on lines
+46
to
+50
| # Some quantumespresso features are developed in separate repositories, with different | ||
| # entry point prefix (e.g. `xspec` in aiida-qe-xspec) | ||
| ENTRY_POINT_MAP = { | ||
| "xspectra": "xspec", | ||
| } |
Member
Author
There was a problem hiding this comment.
@PNOGillespie this resolves the xspectra code auto-installation issue.
c735453 to
f7a369b
Compare
Greater versions require `spglib>=2.5`, which conflict at least with aiidalab-qe-vibroscopy.
c22662c to
429fc47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates two things:
plugins.yaml: all plugins have moved to the AiiDAlab/aiidaplugins organizationsquantumespresso, but e.g.,xspec. However, the QE app's auto-code-installation scheme assumes thequantumespressoprefix. This PR adds a simple mapping patch (thanks @mbercx 🙏)Update
This PR now does more than two things 😅
In the process of updating other plugins, I noticed that we have a circular dependency issue. The newer process tree loads plugins for their process metadata. Since it lives in the common package, when plugins reach out for common things, we get a circular dependency, as the process tree package loads and fetches plugins metadata at the same time.
The solution here is simple - the tree is not common! It is strictly used by the app. Here I move it into the app package.
I also removed the old workchain selector widgets, which we haven't been using in a year or so.
I also pin
hiphiveto1.3.1to avoid conflicts withspglib, which is pinned in at least the muonic plugin.