code/AssetLib/Assbin/AssbinLoader.cpp (1)

728-747: ⚠️ Potential issue | 🟠 Major

Use std::vector for exception-safe buffer management in compressed data decompression.

The current code has a memory leak: ReadBinaryScene(&io, pScene) at line 747 can throw from Read<aiString>() validation, bypassing the cleanup code at lines 749-750. Replace raw pointer allocations with std::vector<unsigned char> for automatic cleanup. Also replace the ai_assert at line 735 with a proper exception throw since read failures are recoverable errors, not programming bugs.

♻️ Proposed RAII fix

 `#include` <assimp/scene.h>
 `#include` <memory>
+#include <vector>
@@
-        unsigned char *compressedData = new unsigned char[compressedSize];
-        size_t len = stream->Read(compressedData, 1, compressedSize);
-        ai_assert(len == compressedSize);
+        std::vector<unsigned char> compressedData(compressedSize);
+        const size_t len = stream->Read(compressedData.data(), 1, compressedSize);
+        if (len != compressedSize) {
+            throw DeadlyImportError("ASSBIN: Unexpected EOF while reading compressed data");
+        }
 
-        unsigned char *uncompressedData = new unsigned char[uncompressedSize];
+        std::vector<unsigned char> uncompressedData(uncompressedSize);
 
-        int res = uncompress(uncompressedData, &uncompressedSize, compressedData, (uLong)len);
+        int res = uncompress(uncompressedData.data(), &uncompressedSize, compressedData.data(), static_cast<uLong>(len));
         if (res != Z_OK) {
-            delete[] uncompressedData;
-            delete[] compressedData;
             throw DeadlyImportError("Zlib decompression failed.");
         }
 
-        MemoryIOStream io(uncompressedData, uncompressedSize);
+        MemoryIOStream io(uncompressedData.data(), uncompressedSize);
 
         ReadBinaryScene(&io, pScene);
-
-        delete[] uncompressedData;
-        delete[] compressedData;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@code/AssetLib/Assbin/AssbinLoader.cpp` around lines 728 - 747, Replace the
raw new[] buffers and ai_assert with exception-safe RAII: allocate compressed
and uncompressed buffers as std::vector<unsigned char> (use
compressedData.data() and uncompressedData.data() when calling stream->Read and
uncompress) so they automatically free on exceptions, and replace the
ai_assert(len == compressedSize) with a proper throw (e.g., throw
DeadlyImportError) when the read returns a different size; keep the rest of the
flow (Read<uint32_t>(stream.get()), MemoryIOStream(io uses
uncompressedData.data(), uncompressedSize), and ReadBinaryScene(&io, pScene))
unchanged so Read<aiString>() exceptions propagate safely without leaking
memory.