Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

Fixed several translations with better English#81

Open
Raymo111 wants to merge 11 commits into
cnwangjie:masterfrom
Raymo111:master
Open

Fixed several translations with better English#81
Raymo111 wants to merge 11 commits into
cnwangjie:masterfrom
Raymo111:master

Conversation

@Raymo111
Copy link
Copy Markdown

Including grammar sentence structure, localized descriptions and capitalization

cnwangjie and others added 11 commits October 23, 2018 20:12
 - perf: dynamic import template & split chunks with popup page
 - change: use drawer & primary color
 - feat: allow import / export file
 - feat: multi items operations
 - feat: detail list pagination
 - feat: hide too much items in detail list
 - refactor: search feature can be used in every page
 - refactor: use drawer
 - depracate: some options have be depracated (removeItemBtnPos, fixedToolbar, enableSearch)
Added better English Translation and examples
Added better and clearer English Translations, fixed grammar and capitalization
Copy link
Copy Markdown
Owner

@cnwangjie cnwangjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your works. But I don't think the most parts of those need to be modified. Maybe I'll use some parts of them. :)

Comment thread .github/ISSUE_TEMPLATE/bug_report.md
Comment thread src/_locales/en/messages.json
@Raymo111
Copy link
Copy Markdown
Author

Sure, just use whatever you need. In my opinion the English could be improved, but it's up to you.

@onefork
Copy link
Copy Markdown

onefork commented Jan 31, 2019

Thanks a lot.

It's still a little bit confusing on the option page.

Under "Behaviour"
Behavior when item in a list is clicked: The options are "open" and "open and remove"
Behavior when item in simple list is clicked: "restore" and "restore in new window"

"An item in a list" means a tab in a tab group while "an item in a simple list" is a tab group, right?
And the "open and remove" option doesn't seem to remove anything.

Best

@kickformoney
Copy link
Copy Markdown

Thanks a lot.

It's still a little bit confusing on the option page.

Under "Behaviour"
Behavior when item in a list is clicked: The options are "open" and "open and remove"
Behavior when item in simple list is clicked: "restore" and "restore in new window"

"An item in a list" means a tab in a tab group while "an item in a simple list" is a tab group, right?
And the "open and remove" option doesn't seem to remove anything.

Best

The Open and Remove option opens the link in a new tab, then removes it from the list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants