Allow defining custom builtins#423
Open
superb-eddie wants to merge 1 commit into
Open
Conversation
geseq
requested changes
Aug 22, 2023
Collaborator
There was a problem hiding this comment.
Thanks for the PR. I like the idea for this but I'm not keen on breaking the NewVM call for current users for what is likely to be a rarer use case.
Can we instead introduce functional options to pass in the builtins. That way the code remains unbroken for all current users and will also allow future introductions of more options while remaining backwards compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature I've found very helpful in my project, SceneEngine.
For my use case, I've got custom user scripts being imported by a runtime script and I need to expose custom builtin functions to that userscript.
I tried creating the builtin as globals, but globals aren't exposed to libraries when they're imported.