New detekt generator Part 2#9141
Draft
BraisGabin wants to merge 6 commits into
Draft
Conversation
d3bc5a6 to
3e5f1e1
Compare
Collaborator
|
a2ac7d2 to
64330e1
Compare
64330e1 to
f4ed8ff
Compare
d8a7e64 to
63856c9
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #9141 +/- ##
============================================
+ Coverage 84.92% 84.98% +0.06%
+ Complexity 4427 4423 -4
============================================
Files 570 570
Lines 12299 12275 -24
Branches 2694 2694
============================================
- Hits 10445 10432 -13
+ Misses 683 672 -11
Partials 1171 1171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
63856c9 to
3a52707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes on top of #9140
After #9140 we can stop commiting the config files. Those are generated files so we shouldn't commit them, gradle knows how and when it should regenerate them and it also knows how to add them to the resources of the final
jarwithout adding them to thesrc/main/resourcesfolder.I see a pro and a con to this PR:
PRO: detekt is easier to contribute you don't need to execute
./gradlew generateDocumentationanymore and commit those changes. That was always a source of errors for new contributors (and no so new contributors too).CON: It was handy to read the yaml diff on the PRs. Some times it was easier to spot problems there than just by reading the rule. And we are loosing that.
I'm not against closing this PR if we think that the CON is too big.