Fix SchemaTable.Updater panic on direct UPDATE dolt_schemas#11059
Open
tbantle22 wants to merge 2 commits into
Open
Fix SchemaTable.Updater panic on direct UPDATE dolt_schemas#11059tbantle22 wants to merge 2 commits into
tbantle22 wants to merge 2 commits into
Conversation
A direct UPDATE dolt_schemas reached SchemaTable.Updater, which
panicked ("should never be called") — an unprivileged user could crash
the SQL server with it. Delegate to the wrapped backing table instead,
which removes the panic and gives the write the same branch_control
gate as any other table write.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dolt_schemas is not directly modifiable via SQL (internal schema changes go through the wrapped backing table). Rather than delegating the direct-UPDATE path to the backing table, return a static error unconditionally so the table stays non-directly-modifiable while no longer panicking. Moves the regression test out of the branch_control block suite (which expects success once Write is granted) into the dolt_schemas script test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
@tbantle22 DOLT
|
Contributor
|
@tbantle22 DOLT
|
Contributor
|
@tbantle22 DOLT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A direct UPDATE dolt_schemas reached SchemaTable.Updater, which panicked with "should never be called" — an unprivileged user could crash the SQL server with it. dolt_schemas is not directly modifiable via SQL, so this returns a clean error unconditionally instead of panicking; adds a regression test.