fix: GCC 15 / C23 compatibility — uint, u_char, _DEFAULT_SOURCE#2035
Open
texasich wants to merge 1 commit into
Open
fix: GCC 15 / C23 compatibility — uint, u_char, _DEFAULT_SOURCE#2035texasich wants to merge 1 commit into
texasich wants to merge 1 commit into
Conversation
GCC 15 defaults to -std=gnu23 (C23), which: - Removes uint and u_char from <sys/types.h> - No longer implicitly defines _DEFAULT_SOURCE, hiding POSIX functions like daemon(3), gai_strerror(3), fileno(3), getaddrinfo(3), and others behind feature-test macros. Changes: - src/iperf.h: add `typedef unsigned int uint` fallback - src/iperf_config.h.in: define _DEFAULT_SOURCE globally - src/iperf_client_api.c, iperf_server_api.c, iperf_tcp.c: add _DEFAULT_SOURCE define before system headers (these files include system headers before iperf_config.h) - src/units.c: s/u_char/unsigned char/ for toupper() cast Tested: builds cleanly with gcc -std=c2x -Werror (GCC 13 name for C23 mode), and with default flags. Fixes esnet#1838
Contributor
|
Thanks for the PR! We'll take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 defaults to
-std=gnu23(C23), which removesuintandu_charfrom<sys/types.h>and no longer implicitly defines_DEFAULT_SOURCE. This hides POSIX functions likedaemon(3),gai_strerror(3),fileno(3),getaddrinfo(3), and others behind feature-test macros.Changes:
src/iperf.h: Addtypedef unsigned int uintcompatibility fallbacksrc/iperf_config.h.in: Define_DEFAULT_SOURCEglobally so all files that include it pick it upsrc/iperf_client_api.c,iperf_server_api.c,iperf_tcp.c: Add_DEFAULT_SOURCEbefore system headers (these files include system headers beforeiperf_config.h)src/units.c: Replaceu_charwithunsigned charin atoupper()castTested:
gcc -std=c2x -Werror— clean build (C23 mode)Fixes #1838.