Update Godot.gitignore#4801
Open
NoahGreer wants to merge 1 commit into
Open
Conversation
|
Tiruturififirifufurururufufufufufuuffuf4
sob., 21 lut 2026, 05:06 użytkownik Noah Greer ***@***.***>
napisał:
… Reasons for making this change
As of Godot <https://godotengine.org/> 4.2 the editor has a
Windows-specific workaround for loading extension libraries. Before the
extension library is loaded the Godot editor creates a temp copy of the
extension library .dll file with a ~ prefix (e.g. example.dll =>
~example.dll). When the extension library is unloaded the Godot editor
deletes the temp copy. These copied ~*.dll files are temporary and should
be ignored.
Links to documentation supporting these rule changes
Godot 4.2 changelog
https://godotengine.org/article/godot-4-2-arrives-in-style/#gdextension
Godot PR #80188 GDExtension: Copy DLL to a temp file before opening
godotengine/godot#80188 <godotengine/godot#80188>
Merge and Approval Steps
- Confirm that you've read the contribution guidelines
<https://github.com/github/gitignore/tree/main?tab=readme-ov-file#contributing-guidelines>
and ensured your PR aligns
- Ensure CI is passing
- Get a review and Approval from one of the maintainers
------------------------------
You can view, comment on, or merge this pull request online at:
#4801
Commit Summary
- 8cd0f4e
<8cd0f4e>
Add rule for Godot temp extension library copies on Windows
File Changes
(1 file <https://github.com/github/gitignore/pull/4801/files>)
- *M* Godot.gitignore
<https://github.com/github/gitignore/pull/4801/files#diff-2ebb77c348d86f88a6bf9b0ee2cc88080f53a72ddd7fd1ae52db3372f98b7001>
(3)
Patch Links:
- https://github.com/github/gitignore/pull/4801.patch
- https://github.com/github/gitignore/pull/4801.diff
—
Reply to this email directly, view it on GitHub
<#4801>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWBQRBLRAA5ZNHJD57YDXU34M7KTPAVCNFSM6AAAAACV3EAOYCVHI2DSMVQWIX3LMV43ASLTON2WKOZTHE3TCMRVGY2TQMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Author
|
Is there anything more I can do to help get this PR ready to be reviewed and merged? I read the contribution guidelines and believe I have followed them correctly. The only thing that remains unclear is how I am expected to complete the step "Ensure CI is passing". The action runner seems to be restricted to repo maintainers, so I presume that this step is something that can only be done by a repo maintainer. |
As of Godot 4.2 the editor has a Windows-specific workaround for loading extension libraries. Before the extension library is loaded the Godot editor creates a temp copy of the extension library `.dll` file with a `~` prefix (e.g. `example.dll` => `~example.dll`). When the extension library is unloaded the Godot editor deletes the temp copy. These copied `~*.dll` files are temporary and should be ignored. References: Godot 4.2 changelog https://godotengine.org/article/godot-4-2-arrives-in-style/#gdextension Godot PR #80188 GDExtension: Copy DLL to a temp file before opening godotengine/godot#80188
8cd0f4e to
bf4440e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
https://godotengine.org/
Reasons for making this change
As of Godot 4.2 the editor has a Windows-specific workaround for loading extension libraries. Before the extension library is loaded the Godot editor creates a temp copy of the extension library
.dllfile with a~prefix (e.g.example.dll=>~example.dll). When the extension library is unloaded the Godot editor deletes the temp copy. These copied~*.dllfiles are temporary and should be ignored.Links to documentation supporting these rule changes
Godot 4.2 changelog
https://godotengine.org/article/godot-4-2-arrives-in-style/#gdextension
Godot PR #80188 GDExtension: Copy DLL to a temp file before opening
godotengine/godot#80188
Merge and Approval Steps