Skip to content

Added ROS2 .msg, .srv and .action files#210

Open
hurst848 wants to merge 1 commit into
google:masterfrom
hurst848:add_ros_messages
Open

Added ROS2 .msg, .srv and .action files#210
hurst848 wants to merge 1 commit into
google:masterfrom
hurst848:add_ros_messages

Conversation

@hurst848
Copy link
Copy Markdown

@hurst848 hurst848 commented Jan 9, 2026

Added .msg, .srv, and .action files for ROS2 messages

@hurst848
Copy link
Copy Markdown
Author

Link to the ROS2 Message spec documentation for reference: https://docs.ros.org/en/rolling/Concepts/Basic/About-Interfaces.html#messages

@tfroseman
Copy link
Copy Markdown
Collaborator

Thanks for the pull request and reference. One change requested is to also add the file extensions into the appropriate place in main_test.go For the # comment style that should be https://github.com/google/addlicense/blob/master/main_test.go#L347

@flwyd
Copy link
Copy Markdown
Contributor

flwyd commented Jan 26, 2026

I would be careful about inferring a file's type based on a .msg extension. Microsoft Outlook uses .msg for emails and other data and as a shorthand for "message" it seems likely for people to use it for data in custom formats. (Similarly, there's no single format for a .log file.) It looks like there are multiple uses of .action as an extension as well, including macOS Automator.

Handling generic extensions like these is a good use case for having an addlicense config file. A standard ROS2 addlicense config could be part of a project template without "claiming" these extensions for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants