Add Run.AddTab() for inserting tab characters#87
Open
theAstiv wants to merge 1 commit into
Open
Conversation
This exposes a public helper on docx.Run consistent with Bold, Italic, Underline, etc. Returns *Run for chaining.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run.AddTab(), which inserts a<w:tab/>element into a run.RunChild.Tab, marshal, unmarshal) was already present; this exposes a public helper ondocx.Runconsistent withBold,Italic,Underline, etc.Motivation
Users wanting tab characters in a run currently have to drop to ctypes directly. python-docx, the inspiration for this library per the README, exposes
run.add_tab()as a first-class helper.Changes
docx/run.go: newAddTab()method, returns*Runfor chaining (consistent with the other chainable*Runmethods in this file).docx/run_test.go: new file with two test cases — single tab with marshal assertion, and chained multi-tab.Testing
go test ./...passes (including existing determinism tests)go vet ./...cleangofmtclean