UI picker refresh#8036
Conversation
…resh # Conflicts: # static/js/humhub/humhub.ui.picker.js
|
@mbumpalumpa can you please review? |
|
@gevorgmansuryan there are some issues and one change. So you can see in the screenshots that the alignment isn't the best. People/Space images are outside of the pill itself, and in the case of Post Type, you can see that the icon is sticking to the bottom rather than being centered. Also, you can see that the pill position in the picker itself looks like the bottom padding/margin is larger. Additionally, the change would be the X within the pill itself. The original concept indeed used the "X" that you implemented; however, the Font Awesome X is way too thick and dominates the pill itself, so we should use Additionally, I would expect pills and pickers to look the same regardless of where they are. You can see that the User Picker Pill in Stream Filter and the User Picker Pill in Group Members look different, aka the pill is larger, which is good. Basically, we currently have two different sizes/heights: 23px and 28px. I would much rather standardize this to 28px across the board. Here is an example of pickers for Design System v2; you can see that all spacing is unified (Ignore the design itself, which is a lot different than what we currently have). |
|
@mbumpalumpa thanks! Should be fixed now |
https://github.com/humhub/humhub-internal/issues/866
https://www.figma.com/design/tshvUVBzxy7uW8eZs6n6IG/HumHub---Design-System?node-id=9190-2038