Add support for other models in AutoEval#59
Open
Divij97 wants to merge 2 commits into
Open
Conversation
4 tasks
Contributor
|
Hey @Divij97 this looks great! Very elegant way to support Anthropic + OpenAI as evaluators. I'm guessing Claude and GPT will need different eval prompts, but this is definitely headed in the right direction. Let me know when this is ready for a full review |
Merged
NivekT
reviewed
Aug 6, 2023
Collaborator
There was a problem hiding this comment.
Hi,
Thanks for opening this PR!
We refactored how experiment.evaluate() work. The TL;DR is that .evaluate() will apply the evaluation function on a row of results at a time (plus any keyword args for the evaluation function).
At a glance, I don't think it should impact this PR but please rebase and let me know if there is any issue.
862ca6e to
30c03a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets targets this feature request