Disable IREE benchmarks in fusilli's captive IREE build#422
Merged
Conversation
IREE PR #24167 (Enable building without google benchmark dependency) added the IREE_BUILD_BENCHMARKS option. Set it OFF here so fusilli's captive IREE doesn't pull google-benchmark via third_party/benchmark.
AaronStGeorge
added a commit
to AaronStGeorge/docker
that referenced
this pull request
May 14, 2026
After iree-org/fusilli#422 fusilli will no longer require IREE to have `third_party/benchmark`. We may want merge this and bump the docker container as part of iree-org/fusilli#422.
sjain-stanford
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In ASan builds of TheRock, an issue in IREE's
third_party/benchmarksubmodule breaks fusilli's CMake configure during IREE's sub-configure. A compiler invocation, inside a capability check, inside IREE's captive benchmark dependency, fails to find the ASan runtime library. This issue would likely only happen in TheRock when using the compiler hermetically created as part of the build.Given that fusilli-provider and fusilli don't use any code paths that require IREE's captive benchmark dependency the easiest path to fix the issue is simply to sidestep it by removing the dependency.
Technical Details
PR iree-org/iree#24167 added an
IREE_BUILD_BENCHMARKSoption. WhenIREE_BUILD_BENCHMARKSandIREE_BUILD_TESTSare both set toOFF, IREE doesn't requirethird_party/benchmark. A follow up PR will remove the dep from fusilli's docker here.