Skip to content

hack/prow: update cri-dockerd to v0.4.3 for the none-driver integration script#22992

Open
rafaelmfried wants to merge 1 commit into
kubernetes:masterfrom
rafaelmfried:fix/none-docker-cri-dockerd-version
Open

hack/prow: update cri-dockerd to v0.4.3 for the none-driver integration script#22992
rafaelmfried wants to merge 1 commit into
kubernetes:masterfrom
rafaelmfried:fix/none-docker-cri-dockerd-version

Conversation

@rafaelmfried
Copy link
Copy Markdown

@rafaelmfried rafaelmfried commented May 17, 2026 •
edited
Loading

Fixes the pull-minikube-none-docker-linux-x86 presubmit, which currently fails on every PR.

The bug

hack/prow/integration_none_docker_linux_x86.sh:48 pins:

CRI_DOCKERD_VERSION="0.4.1"

and downloads cri-dockerd-0.4.1.amd64.tgz from that release tag. But cri-dockerd v0.4.1 was never released — Mirantis/cri-dockerd went from v0.3.25 straight to v0.4.2 / v0.4.3 (releases). The download 404s, tar chokes on the HTML error page, and the job dies in setup before any test runs:

+ tar -C /tmp -xzvf /tmp/cri-dockerd.tgz
gzip: stdin: not in gzip format
tar: Child returned status 1

Why it regressed

#22916 bumped cri-dockerd v0.4.1 → v0.4.3 across kicbase, the ISO packages and the Jenkins none-driver script — but not this Prow script. There was no mechanism to catch it: the script isn't in the schema of hack/update/cri_dockerd_version/cri_dockerd_version.go, so the version updater never rewrites it, and it silently stayed on the broken 0.4.1.

The fix

File Change
hack/prow/integration_none_docker_linux_x86.sh CRI_DOCKERD_VERSION: 0.4.1 → 0.4.3 — the version every other consumer already uses after #22916. v0.4.2 / v0.4.3 are CVE / dependency bumps only, no behaviour change.
hack/update/cri_dockerd_version/cri_dockerd_version.go Adds the script to the updater schema, so future cri-dockerd bumps keep it in sync and it can't drift out again.

The new schema entry only rewrites CRI_DOCKERD_VERSION — the Prow script has no CRI_DOCKERD_COMMIT, unlike the Jenkins one — and uses the unprefixed {{.Version}} to match the script's "0.4.3" form.

Verification

go build and go vet on the hack module pass. The fix is config-only, so the most direct proof is this PR's own pull-minikube-none-docker-linux-x86 run.

Fixes #22991

/kind bug

@rafaelmfried
hack/prow: update cri-dockerd to v0.4.3 for the none-driver integrati…
5362415 
…on script

Signed-off-by: Rafael Moura Friederick <rafael.mf.documents@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 17, 2026

Hi @rafaelmfried. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rafaelmfried
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

minikube-bot commented May 17, 2026

Can one of the admins verify this patch?

@rafaelmfried rafaelmfried mentioned this pull request May 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@medyagh medyagh Awaiting requested review from medyagh

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prow none-docker job fails: integration script pins cri-dockerd v0.4.1, which does not exist

3 participants

@rafaelmfried @k8s-ci-robot @minikube-bot