feat: add Node Readiness Controller (nrc) minikube addon by arnab-logs · Pull Request #22924 · kubernetes/minikube

arnab-logs · 2026-05-01T20:50:17Z

Fixes kubernetes-sigs/node-readiness-controller#188
cc: @ajaysundark

What this PR does

This PR adds a new Minikube addon for the Node Readiness Controller (NRC).

This addon is part of enabling easier adoption and testing of NRC and enables a lifecycle-managed way to deploy NRC in Minikube using: minikube start --addons=nrc

Implementation details

Adds new addon: nrc
Includes:
- NRC controller static Pod manifest
- CRD definition for NodeReadinessRule
Runs in kube-system namespace
Uses control-plane co-located deployment model
Resources are labeled with: kubernetes.io/minikube-addons: nrc

How to test

Build and start

make
./out/minikube start --addons=nrc

Verify installation

kubectl get pods -n kube-system -l component=node-readiness-controller

kubectl get crd nodereadinessrules.readiness.node.x-k8s.io

Verify scheduling (control-plane)

kubectl get pods -n kube-system -l component=node-readiness-controller -o wide

Check logs

kubectl logs -n kube-system -l component=node-readiness-controller

Disable and cleanup

./out/minikube addons disable nrc --alsologtostderr

Verify cleanup:

kubectl get pods -n kube-system -l component=node-readiness-controller
kubectl get crd nodereadinessrules.readiness.node.x-k8s.io

minikube-bot · 2026-05-01T20:57:04Z

Can one of the admins verify this patch?

ajaysundark · 2026-05-02T15:26:40Z

/retest

medyagh · 2026-05-08T18:30:07Z

/ok-to-test

k8s-ci-robot · 2026-05-08T18:32:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arnab-logs
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

Pull request overview

This PR introduces a new Minikube addon (nrc) to deploy the Node Readiness Controller, including its controller Pod manifest and the NodeReadinessRule CRD, enabling minikube start --addons=nrc.

Changes:

Registered a new nrc addon with embedded CRD + controller Pod template and a pinned controller image.
Added nrc to the addons configuration list so it can be enabled/disabled via standard addon flows.
Minor formatting/whitespace-only changes in existing CI/minitest/release scripts.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/minikube/assets/addons.go	Registers the `nrc` addon and its assets/images (but currently introduces a filename collision risk).
pkg/addons/config.go	Adds `nrc` to the addon config list (enable/disable support).
deploy/addons/nrc/nrc.yaml.tmpl	Adds the controller Pod template (scheduling + image templating concerns).
deploy/addons/nrc/crds.yaml	Adds the `NodeReadinessRule` CRD manifest.
deploy/addons/assets.go	Embeds NRC addon assets into the binary.
hack/prow/minitest/tester/vfkit_docker_macos_arm64_integration.go	Formatting-only change.
hack/prow/minitest/main.go	Formatting-only change.
hack/jenkins/release_update_releases_json.go	Formatting-only change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+      path: /etc/kubernetes/admin.conf
+      type: File
+  - name: nrc-kubeconfig
+    emptyDir: {}


+  # Init container to prepare a readable kubeconfig for the non-root manager.
+  initContainers:
+  - name: prepare-kubeconfig
+    image: busybox:latest


+      mountPath: /tmp/kubeconfig
+  containers:
+  - name: manager
+    image: {{.CustomRegistries.NrcController | default .Registries.NrcController}}{{.Images.NrcController}}


+	{
+		name:      "nrc",
+		set:       SetBool,
+		callbacks: []setFn{EnableOrDisableAddon},


 			"Kubetail": "docker.io",
 		}, nil),
+	"nrc": NewAddon([]*BinAsset{
+		MustBinAsset(addons.NrcAssets, "nrc/crds.yaml", vmpath.GuestAddonsDir, "crds.yaml", "0640"),


k8s-ci-robot · 2026-05-08T20:26:05Z

@arnab-logs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-minikube-none-docker-linux-x86	`dceed89`	link	true	`/test pull-minikube-none-docker-linux-x86`
pull-minikube-docker-containerd-linux-x86	`dceed89`	link	true	`/test pull-minikube-docker-containerd-linux-x86`
pull-minikube-docker-containerd-linux-arm	`dceed89`	link	false	`/test pull-minikube-docker-containerd-linux-arm`
pull-minikube-docker-docker-linux-x86	`dceed89`	link	true	`/test pull-minikube-docker-docker-linux-x86`
pull-minikube-kvm-docker-linux-x86	`dceed89`	link	true	`/test pull-minikube-kvm-docker-linux-x86`
pull-minikube-docker-crio-linux-x86	`dceed89`	link	false	`/test pull-minikube-docker-crio-linux-x86`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

minikube-pr-bot · 2026-05-08T20:38:06Z

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22924 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 39.3s    │ 39.1s                  │
│ enable ingress │ 19.2s    │ 19.3s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube start: 38.6s 40.0s 38.4s 39.2s 40.1s
Times for minikube (PR 22924) start: 39.3s 40.7s 37.0s 40.3s 38.1s

Times for minikube ingress: 19.3s 19.3s 18.8s 19.3s 19.3s
Times for minikube (PR 22924) ingress: 19.3s 19.3s 19.8s 19.3s 18.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22924 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.4s    │ 20.2s                  │
│ enable ingress │ 12.4s    │ 11.7s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube start: 18.6s 21.0s 21.6s 19.1s 21.8s
Times for minikube (PR 22924) start: 21.9s 18.4s 21.1s 21.0s 18.7s

Times for minikube ingress: 12.6s 12.7s 12.2s 12.6s 12.1s
Times for minikube (PR 22924) ingress: 12.1s 10.6s 10.6s 12.6s 12.6s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22924 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 17.3s    │ 17.4s                  │
│ enable ingress │ 24.8s    │ 24.3s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube ingress: 25.1s 24.6s 24.6s 25.1s 24.6s
Times for minikube (PR 22924) ingress: 23.1s 24.6s 24.6s 24.6s 24.6s

Times for minikube start: 16.0s 16.8s 16.6s 20.1s 17.1s
Times for minikube (PR 22924) start: 20.1s 16.9s 16.5s 16.9s 16.5s

WIP: NRC addon + lint fixes

eddda94

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 1, 2026

k8s-ci-robot requested review from medyagh and prezha May 1, 2026 20:50

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2026

arnab-logs mentioned this pull request May 1, 2026

feat: minikube addon for NRC kubernetes-sigs/node-readiness-controller#188

Open

fix: add image template and sha256 digest to NRC addon

19330c5

AvineshTripathi mentioned this pull request May 5, 2026

Add Minikube addon support: labeled CRD and static pod deployment for NRC kubernetes-sigs/node-readiness-controller#197

Closed

2 tasks

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 8, 2026

medyagh requested a review from Copilot May 8, 2026 18:30

Copilot started reviewing on behalf of medyagh May 8, 2026 18:31 View session

medyagh requested changes May 8, 2026

View reviewed changes

Comment thread hack/prow/minitest/tester/vfkit_docker_macos_arm64_integration.go Outdated

Comment thread hack/prow/minitest/main.go

Copilot AI reviewed May 8, 2026

View reviewed changes

revert unrelated formatting changes

dceed89

arnab-logs requested a review from medyagh May 8, 2026 19:14

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Node Readiness Controller (nrc) minikube addon#22924

feat: add Node Readiness Controller (nrc) minikube addon#22924
arnab-logs wants to merge 3 commits into
kubernetes:masterfrom
arnab-logs:feat/add-nrc-addon

arnab-logs commented May 1, 2026

Uh oh!

minikube-bot commented May 1, 2026

Uh oh!

ajaysundark commented May 2, 2026

Uh oh!

medyagh commented May 8, 2026

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented May 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This comment has been minimized.

k8s-ci-robot commented May 8, 2026 •

edited

Loading

Uh oh!

minikube-pr-bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

arnab-logs commented May 1, 2026

What this PR does

Implementation details

How to test

Build and start

Verify installation

Verify scheduling (control-plane)

Check logs

Disable and cleanup

Verify cleanup:

Uh oh!

minikube-bot commented May 1, 2026

Uh oh!

ajaysundark commented May 2, 2026

Uh oh!

medyagh commented May 8, 2026

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

This comment has been minimized.

k8s-ci-robot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

minikube-pr-bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

k8s-ci-robot commented May 8, 2026 •

edited

Loading