Refactor AssertEvents expect() and related methods to use EventAssertion equivalents.#48752
Refactor AssertEvents expect() and related methods to use EventAssertion equivalents.#48752lhanusov wants to merge 1 commit into
Conversation
cfc6ede to
0728df3
Compare
f9ad38c to
de3728f
Compare
| .details(Details.PREVIOUS_LAST_NAME, "Brady").details(Details.UPDATED_LAST_NAME, "LastCC") | ||
| ; |
There was a problem hiding this comment.
| .details(Details.PREVIOUS_LAST_NAME, "Brady").details(Details.UPDATED_LAST_NAME, "LastCC") | |
| ; | |
| .details(Details.PREVIOUS_LAST_NAME, "Brady").details(Details.UPDATED_LAST_NAME, "LastCC"); |
| .details(Details.EMAIL, "login@test.com") | ||
| .sessionId(null) | ||
| ; |
There was a problem hiding this comment.
| .details(Details.EMAIL, "login@test.com") | |
| .sessionId(null) | |
| ; | |
| .details(Details.EMAIL, "login@test.com") | |
| .sessionId(null); |
| .details(Details.FIELDS_TO_UPDATE, "department") | ||
| ; |
There was a problem hiding this comment.
| .details(Details.FIELDS_TO_UPDATE, "department") | |
| ; | |
| .details(Details.FIELDS_TO_UPDATE, "department"); |
05160f1 to
1a2f39c
Compare
| @@ -76,6 +76,28 @@ public R poll() { | |||
| return events.poll(); | |||
| } | |||
|
|
|||
| public R poll(int seconds) { | |||
There was a problem hiding this comment.
This shouldn't be added here and would be considered generally bad practice to use this one.
The two brute force tests should handle internally in the test.
The RecoveryAuthnCodesAuthenticatorTest is honestly not very well written as its sending two requests without waiting, but it will be a bit random if one page is done before the other, and the whole clickSignInButtonViaJavaScriptNoDelay is just weird. I'd say this one should really click the buttoms in separate threads or something like that, then wait for both browers to be redirected, then it can just use events.poll()
There was a problem hiding this comment.
I've tried to fix it, but the problem is with the HtmlUnitDriver, I will try something tomorrow, but don't think I will be successful.
df60bf1 to
117d7cc
Compare
…ion equivalents. Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
Closes #48621