Skip to content

fix: prevent service account name from being set in multi-namespace mode#49036

Open
shawkins wants to merge 1 commit into
keycloak:mainfrom
shawkins:iss48382
Open

fix: prevent service account name from being set in multi-namespace mode#49036
shawkins wants to merge 1 commit into
keycloak:mainfrom
shawkins:iss48382

Conversation

@shawkins
Copy link
Copy Markdown
Contributor

@shawkins shawkins commented May 16, 2026

closes: #48382

@shawkins
fix: prevent service account name from being set in multi-namespace mode
49de3ce 
closes: keycloak#48382

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins shawkins requested review from a team as code owners May 16, 2026 16:23
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 16, 2026
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented May 16, 2026

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.MultipleTabsLoginTest#testWithAuthSessionExpiredInTheMiddle_badRedirectUri

Keycloak CI - Forms IT (chrome)

org.opentest4j.AssertionFailedError: Expected ErrorPage but was localhost (https://localhost:8543/auth/realms/test/login-actions/authenticate?execution=36683f3e-daa8-4562-b03b-8f487cdd28d2&client_id=test-app&tab_id=8s7CLfjx5Cw&client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIn0) ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent the unsupported pod template from specifying the service account in cluster wide mode

1 participant

@shawkins