Reject malformed requests in DockerEndpoint#49042
Closed
abhishekS14 wants to merge 3 commits into
Closed
Conversation
This reverts commit 16967be.
chore: reject malformed requests in DockerEndpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed off: Abhishek Supsande([abhisheksupsande7@gmail.com])
Solves #49009
Reject malformed authorization requests in DockerEndpoint
Add validation for AuthorizationEndpointRequest.getInvalidRequestMessage()
after parseRequest() in DockerEndpoint.build().
Previously, malformed requests (such as duplicated query parameters)
were accepted and processed because the Docker auth flow ignored parser
validation results. This allowed malformed scope parameters to bypass
request validation policies.
The fix aligns Docker endpoint behaviour with the OIDC authorization
endpoint, which already rejects invalid requests via
AuthorizationEndpointChecker.checkInvalidRequestMessage().
PS - Couldn't find a relevant test class to add a test. Can push a new unit test class for DockerEndpoint.