Add working contract preferences to user when setting for the first time from API#5894
Open
viggou wants to merge 5 commits into
Open
Add working contract preferences to user when setting for the first time from API#5894viggou wants to merge 5 commits into
viggou wants to merge 5 commits into
Conversation
|
|
8ae9d26 to
a9ad67e
Compare
Member
|
Thanks for trying to solve the issue. |
a9ad67e to
1670308
Compare
Author
|
I've created a new EventSubscriber which adds the work contract preferences. I'm not sure if you want them in UserPreferenceSubscriber instead? What do you think? |
Member
|
Make it even more generic: something like a |
Author
|
Alright, I added a RegisterUserPreferencesEvent, which only takes user and I've kept the WorkContractPreferenceSubscriber as the listener. The new event is dispatched by UserPreferenceSubscriber. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request allows the public API to add preferences to users if they haven't been set before in the web ui. Fixes this issue #5751
Types of changes
Checklist
composer code-check)