lunatik: add lunatik_assert for internal state checks#509
Draft
lneto wants to merge 1 commit into
Draft
Conversation
Replace luaL_argcheck(L, cond, 1, msg) used for internal object state checks with a new lunatik_assert(L, cond, msg) macro that calls luaL_error directly, avoiding the misleading "bad argument #1" prefix. Applied to: skb not-set, FRAGLIST GSO, linearization failure, forward preconditions in luaskb; read-only check in luadata; module-load and softirq-context guards in luathread. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
carloslack
reviewed
Mar 18, 2026
| #define luaskb_checkfraglist(L, lskb, ix) \ | ||
| luaL_argcheck(L, !(skb_shinfo((lskb)->skb)->gso_type & \ | ||
| SKB_GSO_FRAGLIST), (ix), "FRAGLIST GSO skbs cannot be copied") | ||
| #define luaskb_checkfraglist(L, lskb) \ |
Contributor
Author
There was a problem hiding this comment.
beacause of \ alingment?
Collaborator
There was a problem hiding this comment.
No, it looks it is a space after ) , is it github thing?
lneto
commented
Mar 18, 2026
|
|
||
| #define lunatik_enomem(L) luaL_error((L), "not enough memory") | ||
|
|
||
| static inline void lunatik_assert(lua_State *L, bool cond, const char *msg) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure it's gonna work because of __no_return.. need to check.. however, I'm still in doubt of this new API.. problem I see with argcheck everywhere is the "bad self" error message.. but I'm not sure it's worth.. what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace luaL_argcheck(L, cond, 1, msg) used for internal object state checks with a new lunatik_assert(L, cond, msg) macro that calls luaL_error directly, avoiding the misleading "bad argument #1" prefix.
Applied to: skb not-set, FRAGLIST GSO, linearization failure, forward preconditions in luaskb; read-only check in luadata; module-load and softirq-context guards in luathread.