Surface Blit implementation#147
Open
brccabral wants to merge 1 commit into
Open
Conversation
… the final blit rectangle after all clipping. SDL3 it is const.
AMDmi3
requested changes
Sep 8, 2025
| void Surface::Blit(const Optional<Rect>& srcrect, Surface& dst, const Rect& dstrect) { | ||
| SDL_Rect tmpdstrect = dstrect; // 4th argument is non-const; does it modify rect? | ||
| if (SDL_BlitSurface(surface_, srcrect ? &*srcrect : nullptr, dst.Get(), &tmpdstrect) != 0) | ||
| void Surface::Blit(const Optional<Rect>& srcrect, Surface& dst, Optional<Rect>& dstrect) { |
Member
There was a problem hiding this comment.
Let's make it const.
- We're going to switch to SDL3 at some point and we don't need incompatible changes.
- Non-const argument does not allow passing rvalue which is inconvenient.
| /// | ||
| /// \throws SDL2pp::Exception | ||
| /// | ||
| /// \see http://wiki.libsdl.org/SDL_BlitSurface |
Member
There was a problem hiding this comment.
Legacy url does not need to be retained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SDL2 SDL_BlitSurface dstrect can be NULL, and it gets updated with the final blit rectangle after all clipping. SDL3 it is const.