CI: Add docbook-cs linting#5524
Conversation
TimWolla
left a comment
There was a problem hiding this comment.
Some remarks for the workflow definition. Didn't look at the tool itself, but the premise sounds good to me.
TimWolla
left a comment
There was a problem hiding this comment.
Some more quick GHA comments. Will need to think about the git / checkout usage more at a later point.
|
I am planning to merge Docbook-cs in a few days as all feedback has been addressed. Please let me know if there are comments, objections or concerns regarding this new tool. So to say any feedback is welcome. |
|
|
||
| - name: "Install docbook-cs" | ||
| working-directory: "${{ matrix.language }}" | ||
| run: composer require jordikroon/docbook-cs:^1.1 staabm/annotate-pull-request-from-checkstyle:^1.8 |
There was a problem hiding this comment.
cs2pr can be installed with setup-php (which might have it cached) and doesn't require a manual composer installation. I recommend moving to that.
See: https://github.com/shivammathur/setup-php#wrench-tools-support
As announced here: https://news-web.php.net/php.doc/969388652
See for test implementation: #5510
The sniffer includes:
This also makes check-whitespaces.xml obsolete, as the sniffer will check for that as well.
The sniffer also covers #5445
<simpara>should be used instead of<para><classname>that should use<exceptionname>instead.