Update a single text description "PRIVATE KEY"#2884
Open
DoctorD90 wants to merge 1 commit into
Open
Conversation
The term "RSA PRIVATE KEY" has been replaced with the more general "PRIVATE KEY" as ECC keys are also accepted. Please note that keys based on "Curve25519" and "Curve 448" (Ed25519/Ed448) for SSL/TLS server certificates are not yet supported by browsers, so they would cause an error during navigation if used. According to the [Baseline Requirements for TLS Server Certificates](https://cabforum.org/working-groups/server/baseline-requirements/documents/), specifically section 6.1.5, currently only RSA keys greater than 2048 bits and ECDSA keys (NIST P-256, NIST P-384, or NIST P-521) are accepted. Signed-off-by: DoctorD90 <DoctorD90@users.noreply.github.com>
Author
|
@yubiuser I hope everything goes smoothly this time... Thanks for your guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Extend the meaning of “PRIVATE KEY” in the
webserver.tls.certdescription to include RSA and ECC keys.How does this PR accomplish the above?:
The term “RSA PRIVATE KEY” has been replaced with the more general “PRIVATE KEY,” as ECC keys are also accepted.
I also followed the instruction received in #2883
Link documentation PRs if any are needed to support this PR:
Please note that keys based on “Curve25519” and “Curve 448” (Ed25519/Ed448) for SSL/TLS server certificates are not yet supported by browsers, so they would cause an error during navigation if used.
According to the Baseline Requirements for TLS Server Certificates, specifically section 6.1.5, currently only RSA keys greater than 2048 bits and ECDSA keys (NIST P-256, NIST P-384, or NIST P-521) are accepted.
This is merely a note for future reference.
By submitting this pull request, I confirm the following:
git rebase)