Implement manual incident subscribers notification#715
Open
Pefington wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I do not know if you actually want this change, but I had to make it, so I am sharing in case you want it.
Summary
Adds subscriber notifications for manually created incidents, and fixes a broken "View Maintenance Details" link in maintenance notification emails.
Changes
c3a11901feat: implement manual incident subscribers notificationsA "Notify Subscribers" toggle is added to the incident UI, visible and enabled by default on new incidents, shown as a disabled "Subscribers have been notified" on existing ones.
NotifySubscribersForIncident(incident_id, title, state, update_text)inincidentController.tsalertingQueue.tsrefactored to call it instead of inlinesubscriberQueue.push()notify_subscribersfield added toIncidentInputand wired through the API handler1b181c08fix: make maintenance email link point to public maintenance pageThe "View Maintenance Details" CTA in maintenance notification emails was linking to
/maintenances/{maintenance_id}, causing a 404 since event IDs differ from maintenance IDs. Appending?type=maintenanceresolves this.How to test