Skip to content

Implement manual incident subscribers notification#715

Open
Pefington wants to merge 2 commits into
rajnandan1:mainfrom
parkpow:feat/publishable-manual-incident
Open

Implement manual incident subscribers notification#715
Pefington wants to merge 2 commits into
rajnandan1:mainfrom
parkpow:feat/publishable-manual-incident

Conversation

@Pefington
Copy link
Copy Markdown

@Pefington Pefington commented Apr 21, 2026

Hi, I do not know if you actually want this change, but I had to make it, so I am sharing in case you want it.

Summary

Adds subscriber notifications for manually created incidents, and fixes a broken "View Maintenance Details" link in maintenance notification emails.

Changes

c3a11901 feat: implement manual incident subscribers notifications

A "Notify Subscribers" toggle is added to the incident UI, visible and enabled by default on new incidents, shown as a disabled "Subscribers have been notified" on existing ones.

image image
  • New NotifySubscribersForIncident(incident_id, title, state, update_text) in incidentController.ts
  • alertingQueue.ts refactored to call it instead of inline subscriberQueue.push()
  • Incident admin UI: "Notify Subscribers" toggle on new incidents, separate toggle for comments
  • notify_subscribers field added to IncidentInput and wired through the API handler

1b181c08 fix: make maintenance email link point to public maintenance page

The "View Maintenance Details" CTA in maintenance notification emails was linking to /maintenances/{maintenance_id}, causing a 404 since event IDs differ from maintenance IDs. Appending ?type=maintenance resolves this.

How to test

  1. Create a new incident with the "Notify Subscribers" toggle enabled → subscribers should receive an email notification
  2. On an existing incident, verify the toggle reads "Subscribers have been notified" and is disabled
  3. Add a comment to an incident with "Notify Subscribers" enabled → subscribers should receive the comment notification
  4. Trigger a maintenance notification email → click "View Maintenance Details" → should land on the correct public maintenance page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant