Add Apple Silicon Metal guardrails#600
Open
luoyuctl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-llama-cppinitializesGGML_ASSERT([rsets->data count] == 0)crashesCLAUDE.mdWhy
On Apple Silicon,
qmd querycurrently fails in two different ways:ggml_metal_device_freedue to residency set cleanup assertions.qmd queryexits non-zero even though retrieval already succeeded.This patch keeps the GPU path enabled, applies the minimal Metal workarounds before llama init, and degrades reranking gracefully when the reranker backend is unavailable.
Verification
pnpm exec vitest run test/llm.test.ts --reporter=verbose -t "Apple Silicon Metal workarounds"pnpm exec vitest run test/llm.test.ts --reporter=verbose -t "QMD_APPLE_METAL_WORKAROUNDS resolution"pnpm exec vitest run test/store.test.ts --reporter=verbose -t "rerank falls back to retrieval order when reranker fails"pnpm exec tsx src/cli/qmd.ts query "test" -n 1Notes
pnpm buildcurrently fails in this checkout with an unrelated existing TypeScript error insrc/store.ts(Property transaction does not exist on type Database). I did not modify that code path.QMD_APPLE_METAL_WORKAROUNDS=offopt-outs of the automatic Metal env patching if someone wants the old behavior.Fixes #368
Fixes #388