Add compatibility layer for Firefox Android#5215
Conversation
~/p/tridactyl (android_gates|✔) $ node_modules/.bin/eslint --rulesdir custom-eslint-rules --ext .ts . | awk '{print $3}' | sort | uniq
bookmarks.create
bookmarks.getTree
bookmarks.remove
bookmarks.search
commands.getAll
commands.onCommand
commands.update
find.find
history.search
omnibox.onInputEntered
omnibox.setDefaultSuggestion
problems
runtime.sendNativeMessage
search.get
search.search
sessions.getRecentlyClosed
sessions.getTabValue
sessions.getWindowValue
sessions.removeTabValue
sessions.removeWindowValue
sessions.restore
sessions.setTabValue
sessions.setWindowValue
sidebarAction.close
sidebarAction.open
sidebarAction.setPanel
sidebarAction.toggle
tabs.discard
tabs.duplicate
tabs.getZoom
tabs.hide
tabs.move
tabs.onMoved
tabs.setZoom
tabs.show
tabs.toggleReaderMode
windows.get
windows.getAll
windows.getCurrent
windows.getLastFocused
windows.remove
windows.update |
|
it looks like Firefox Android doesn't support i swear i remember using it before so i guess they tore it out when they quantum-ified it |
| export const windows = { | ||
| create: async (props: browser.windows._CreateCreateData) => { | ||
| if (!(await isAndroid())) { | ||
| // eslint-disable-next-line unsupported-apis |
There was a problem hiding this comment.
one problem with this pattern is that we're promising to support all browsers that reach this line
not sure if there's an obvious fix?
There was a problem hiding this comment.
It might be useful to simply put such questions on https://support.mozilla.org/
|
Made some decent progress on this two things are annoying me:
|
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/getPlatformInfo i guess we need to add a mock for it |
In theory #4413 should just become a game of whack-a-mole now working through the errors and adding compat / notImplemented to them