Add perf markers to hint filtering and fix perf commands#5343
Open
repparw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds performance profiling infrastructure for hint filtering and fixes bugs in the existing perf commands.
Changes
1. Perf markers in hint filtering (
src/content/hinting.ts)Added
Perf.Markerinstrumentation tofilterHintsSimpleandfilterHintsVimperatorfunctions to measure hint filtering performance:filterHintsSimple- measures simple prefix-based hint filteringfilterHintsVimperator- measures vimperator-style hint filtering with text matchingThese markers allow benchmarking hint filtering performance before/after optimizations.
2. Fixed perfdump/perfhistogram commands (
src/excmds.ts)The original implementation used
open("data:...")to display results, which is blocked by Firefox for extensions due to security restrictions. Changed to:3. Fixed StatsFilter.matches() (
src/perf.ts)Fixed a bug where
StatsFilter.matches()would crash when processing performance entries that don't match the expectedtri/Owner/Function:suffixnaming pattern. Added null check to handle entries that can't be parsed.Usage
To profile hint filtering performance:
This enables measuring and comparing hint filtering performance on pages with many links (e.g., GitHub file listings).