Skip to content

Conversation

@JimWilcox3
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Doc Update

⤵️ What is the current behavior?

Currently, the readme.txt says only to add the theme to the MainActivity if you want to use the AppCompat versions. This only works for the MainActivity. The theme either needs to be added to each activity or to the "application" entry in AndroidManifest.xml;

🆕 What is the new behavior (if this is a feature change)?

Verbiage

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Create an Android App that uses AppCompat and try to navigate to a ViewModel where the View does have the Theme attribute.

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • [ X] All projects build
  • [X ] Follows style guide lines (code style guide)
  • [X ] Relevant documentation was updated (docs style guide)
  • [ X] Rebased onto current develop

@Cheesebaron Cheesebaron merged commit b4d113a into MvvmCross:develop Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants